[PATCH] D72619: [mlir] NFC: Rename index_t to index_type

[Rainer Orth via Phabricator via llvm-commits]

ro added a comment.

In D72619#1817169 <https://reviews.llvm.org/D72619#1817169>, @nicolasvasilache wrote:

> Hello Rainer,
>
> could we sed this to `index_type` instead and address the `_t` suffix once and for all as you suggest in your description of the problem?
>  I am not attached to `_t` and I see the downside now.


Sure, done now.  Tested as before.

However, while all mlir tests PASS on Solaris/amd64, there are some failures on Solaris/sparcv9 (which existed before, the patch is just meant to address the compile failure).

  MLIR-Unit :: TableGen/./MLIRTableGenTests/StructsGenTest.GetElements
  
  MLIR :: AffineOps/ops.mlir
  MLIR :: Conversion/GPUToSPIRV/simple.mlir
  MLIR :: Conversion/LoopsToGPU/imperfect_linalg.mlir
  MLIR :: Conversion/StandardToLLVM/convert-to-llvmir.mlir
  MLIR :: Conversion/StandardToSPIRV/legalization.mlir
  MLIR :: Conversion/StandardToSPIRV/std-to-spirv.mlir
  MLIR :: Conversion/StandardToSPIRV/subview-to-spirv.mlir
  MLIR :: Conversion/VectorToLoops/vector-to-loops.mlir
  MLIR :: Dialect/FxpMathOps/lower-uniform-casts.mlir
  MLIR :: Dialect/FxpMathOps/lower-uniform-real-math-addew.mlir
  MLIR :: Dialect/FxpMathOps/lower-uniform-real-math-mulew.mlir
  MLIR :: Dialect/LLVMIR/roundtrip.mlir
  MLIR :: Dialect/Linalg/fusion-2-level.mlir
  MLIR :: Dialect/Linalg/fusion.mlir
  MLIR :: Dialect/Linalg/promote.mlir
  MLIR :: Dialect/Linalg/tile.mlir
  MLIR :: Dialect/Linalg/tile_conv.mlir
  MLIR :: Dialect/Linalg/tile_indexed_generic.mlir
  MLIR :: Dialect/Linalg/transform-patterns.mlir
  MLIR :: Dialect/QuantOps/canonicalize.mlir
  MLIR :: Dialect/QuantOps/convert-const.mlir
  MLIR :: Dialect/SPIRV/Serialization/constant.mlir
  MLIR :: Dialect/SPIRV/Transforms/abi-load-store.mlir
  MLIR :: Dialect/SPIRV/Transforms/abi-simple.mlir
  MLIR :: Dialect/SPIRV/canonicalize.mlir
  MLIR :: Dialect/SPIRV/structure-ops.mlir
  MLIR :: Dialect/SPIRV/target-and-abi.mlir
  MLIR :: Dialect/VectorOps/invalid.mlir
  MLIR :: Dialect/VectorOps/ops.mlir
  MLIR :: IR/attribute.mlir
  MLIR :: IR/core-ops.mlir
  MLIR :: IR/invalid-ops.mlir
  MLIR :: IR/parser.mlir
  MLIR :: IR/pretty-attributes.mlir
  MLIR :: IR/traits.mlir
  MLIR :: Quantizer/matmul.mlir
  MLIR :: Target/llvmir.mlir
  MLIR :: Transforms/Vectorize/vectorize_1d.mlir
  MLIR :: Transforms/Vectorize/vectorize_2d.mlir
  MLIR :: Transforms/canonicalize.mlir
  MLIR :: Transforms/constant-fold.mlir
  MLIR :: mlir-cpu-runner/linalg_integration_test.mlir
  MLIR :: mlir-cpu-runner/simple.mlir
  MLIR :: mlir-cpu-runner/unranked_memref.mlir
  MLIR :: mlir-cpu-runner/utils.mlir
  MLIR :: mlir-tblgen/pattern.mlir

I haven't even started looking what might be wrong here (endianess issue?).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72619/new/

https://reviews.llvm.org/D72619