[PATCH] D71870: [llvm-locstats] Add the --compare option

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added a comment.

In D71870#1820417 <https://reviews.llvm.org/D71870#1820417>, @aprantl wrote:

> In D71870#1819207 <https://reviews.llvm.org/D71870#1819207>, @djtodoro wrote:
>
> > In D71870#1816443 <https://reviews.llvm.org/D71870#1816443>, @djtodoro wrote:
> >
> > > @aprantl Thanks for the comment, sorry for the late response, I was on the vacation.
> > >
> > > In D71870#1810823 <https://reviews.llvm.org/D71870#1810823>, @aprantl wrote:
> > >
> > > > How ubiquitous is matplotlib? I wonder if it might be better to textually print out a gnuplot file or something similar. OTOH the surface area in the code seems to be really small, so this may be fine.
> > >
> > >
> > > I see the matplotlib is used within some of the LLVM Python tools, but I can investigate this further in order to see if the gnuplot is better option for this.
> >
> >
> > @aprantl For this option I would keep using the `matplotlib` (there is a help message saying we need the library,  please see e.g. `clang/utils/analyzer/CmpRuns.py`).
> >  Although, I think the gnuplot could be useful as well, but I don't see any obstacle that both ways of plotting coexist here, so we can add another feature to the llvm-locstats tool generating a gnuplot text file. WDYT?
>
>
> Gnuplot also has a weird license and I don't necessarily want to introduce it as a dependency either. But some form of dumping the raw data that is being graphed into some sort of machine-readable output (perhaps CSV?) could be useful for importing it into other tools like spreadsheets, pgfplot, gnuplot and so on.


That sounds like a very good idea! Having something like that will be useful, and we should make a proposal for that. Thanks for the review!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71870/new/

https://reviews.llvm.org/D71870