[PATCH] D72585: [MLIR] Fixes for BUILD_SHARED_LIBS=on

Alex Zinenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 15 00:08:37 PST 2020


ftynse added a comment.

I think this goes into the right direction. The issue with this patch is that it removes some libraries from `add_dependency` for some targets, but not all of them, thus creating more inconsistency than we already have.  Could you make it consistent for all targets and, if possible and in a follow up, add a doc that says how to properly set up a library for a new dialect.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72585/new/

https://reviews.llvm.org/D72585





More information about the llvm-commits mailing list