[PATCH] D72432: [mlir] Add shaped container component type interface

[River Riddle via Phabricator via llvm-commits]

rriddle added inline comments.


================
Comment at: mlir/include/mlir/Analysis/InferTypeOpInterface.h:31
+///  - A element type, may be unset (nullptr)
+///  - A attribute, may be unset (nullptr)
+/// Used by ShapedType type inferences.
----------------
I don't understand what the use case for the attribute is.


================
Comment at: mlir/include/mlir/Analysis/InferTypeOpInterface.h:47
+        attr(attr) {}
+  ShapedTypeComponents(ArrayRef<int64_t> vec, Type elementType = nullptr,
+                       Attribute attr = nullptr)
----------------
Seems like there is no constructor for the unranked case that can initialize the element type and attribute.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72432/new/

https://reviews.llvm.org/D72432