[PATCH] D71773: [AArch64][SVE] Update the definition of AdvSIMD_GatherLoad_VecTorBase_Intrinsic

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 14 17:22:38 PST 2020


efriedma added a comment.

This makes sense.



================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:12207
+  // offsets use GLD1 or GLD1_UXTW instead.
+  if (Opcode == AArch64ISD::GLD1_IMM && !isa<ConstantSDNode>(Offset.getNode())) {
+    if (MVT::nxv4i32 == Base.getValueType().getSimpleVT().SimpleTy)
----------------
Do you need to handle the possibility that Offset is an immediate, but can't be encoded into a GLD1_IMM?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71773/new/

https://reviews.llvm.org/D71773





More information about the llvm-commits mailing list