[PATCH] D72741: [MLIR] LLVM dialect: Add llvm.atomicrmw

JF Bastien via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 14 16:23:34 PST 2020


jfb added inline comments.


================
Comment at: mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td:759
+def AtomicOrderingUnordered              : I64EnumAttrCase<"unordered", 1>;
+def AtomicOrderingMonotonic              : I64EnumAttrCase<"monotonic", 2>;
+def AtomicOrderingAcquire                : I64EnumAttrCase<"acquire", 4>;
----------------
Could you call this one relaxed, so it matches C++, instead of the LLVM IR name?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72741/new/

https://reviews.llvm.org/D72741





More information about the llvm-commits mailing list