[PATCH] D72739: [SLP] Add a test showing miscompilation in AltOpcode support

Alexey Bataev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 14 16:02:31 PST 2020


ABataev added inline comments.


================
Comment at: llvm/test/Transforms/SLPVectorizer/X86/no_alternate_divrem.ll:4-5
+
+target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-unknown-linux-gnu"
+define void @test_add_sdiv(i32 *%arr1, i32 *%arr2, i32 %a0, i32 %a1, i32 %a2, i32 %a3) #0 {
----------------
Better to pass these as parameters of opt.


================
Comment at: llvm/test/Transforms/SLPVectorizer/X86/no_alternate_divrem.ll:134
+}
+attributes #0 = { "target-cpu"="core-avx2" "target-features"="+avx,+avx2" }
----------------
Same here, pass as a parameter of opt instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72739/new/

https://reviews.llvm.org/D72739





More information about the llvm-commits mailing list