[PATCH] D71467: [FPEnv] Generate constrained FP comparisons from clang

John McCall via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 14 13:38:23 PST 2020


rjmccall added a comment.

> Well, just like for all the other FP builder methods, you can use the setIsFPConstrained method on the builder object to switch between strict and non-strict mode. Does this not suffice, or is there anything particular about the comparisons that would require anything extra?

Ah, sorry, I forgot that `IsFPConstrained` is about whether we emit the intrinsics at all and not whether the intrinsics are currently recording real constraints.

I think I have a slight preference for the second option, where there's a single method that does all the work for the two cases.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71467/new/

https://reviews.llvm.org/D71467





More information about the llvm-commits mailing list