[PATCH] D71835: [llvm-readobj] - Remove an excessive helper for printing dynamic tags.

Tue Jan 14 11:42:14 PST 2020

MaskRay added a comment.

In D71835#1818892 <https://reviews.llvm.org/D71835#1818892>, @grimar wrote:

> Assuming we want to keep them, I am thinking about shortening and lower-casing:
>
>   0x0000000012345678 (unknown) 0x8765432187654321
>   0x000000006abcdef0 (OS specific) 0x9988776655443322
>   0x0000000076543210 (processor specific) 0x5555666677778888
>

This looks good.

In D71835#1818970 <https://reviews.llvm.org/D71835#1818970>, @jhenderson wrote:

> In D71835#1817700 <https://reviews.llvm.org/D71835#1817700>, @MaskRay wrote:
>
> > I think our goal is to make llvm-readobj -d and llvm-readelf -d consistent.
>
>
> FWIW, I don't see a massive need for this (we don't make, e.g. symbol output consistent), but I don't oppose attempting it as long as llvm-readelf output is consistent with GNU readelf.

I was postulating the original intention of this patch: make things consistent in places where the exact llvm-readobj -d output does not matter that much / share code. In GNU readelf's output, the second column duplicates some information from the first column, so it is not ideal.

  0x0000000012345678 (<unknown>: 12345678) 0x8765432187654321
  0x000000006abcdef0 (Operating System specific: 6abcdef0) 0x9988776655443322
  0x0000000076543210 (Processor Specific: 76543210) 0x5555666677778888

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71835/new/

https://reviews.llvm.org/D71835