[PATCH] D72517: [lld/ELF] PR44498: Support input filename in double quote

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre marked 2 inline comments as done.
thopre added a comment.

In D72517#1814982 <https://reviews.llvm.org/D72517#1814982>, @MaskRay wrote:

> >   allows to fix a failure in ELF/linkerscript/filename-spec.s when the path contain a @ which the lexer consider as a special characters and thus break up a filename containing it.
>
> Which one?


See updated description. Jenkins sometimes create workspace with an @2 in them so if the repo is cloned into that path test filename will have an @ which will confuse the lexer on that line. It'll break the filename just before the @ and will create a matcher for that rather than the full path.



================
Comment at: lld/test/ELF/linkerscript/filename-spec.s:33
 
-# RUN: echo "SECTIONS{.foo :{ %/t.dir/filename-spec2.o(.foo) %/t.dir/filename-spec1.o(.foo) }}" > %t5.script
+# RUN: echo "SECTIONS{.foo :{ \"%/t.dir/filename-spec2.o\"(.foo) \"%/t.dir/filename-spec1.o\"(.foo) }}" > %t5.script
 # RUN: ld.lld -o %t5 --script %t5.script \
----------------
MaskRay wrote:
> Un-quote this test so that we won't lose coverage for unquoted strings.
The problem is that this patch was created precisely to deal with this line failing when the path to the test contains a special character, which happens under jenkins (see updated description).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72517/new/

https://reviews.llvm.org/D72517