[PATCH] D69372: [X86][VARARG] Avoid spilling xmm vararg arguments.

Alexey Lapshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 14 10:51:34 PST 2020


avl marked 3 inline comments as done.
avl added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ExpandPseudo.cpp:250
+
+    // skip CFI instructions
+    if (CurStackRestoreInstr->isCFIInstruction())
----------------
rnk wrote:
> This looks like a lot of very fragile pattern matching. I would greatly prefer it if we didn't have to do this.
would rewrite it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69372/new/

https://reviews.llvm.org/D69372





More information about the llvm-commits mailing list