[PATCH] D72711: [ThinLTO] Handle variable with twice promoted name (Rust)

[Wei Mi via Phabricator via llvm-commits]

wmi accepted this revision.
wmi added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/include/llvm/IR/ModuleSummaryIndex.h:1271
   /// Helper to obtain the unpromoted name for a global value (or the original
-  /// name if not promoted).
+  /// name if not promoted). Split off the rightmost ".llvm.${hash}" suffix.
   static StringRef getOriginalNameBeforePromote(StringRef Name) {
----------------
I see that the patch and test descriptions are already very informative about why two rounds of promotion is possible and why rightmost split off is needed for internalizing. Maybe briefly mention two rounds of promotion here to let the reader conveniently know which side chose to split off is not arbitrary.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72711/new/

https://reviews.llvm.org/D72711