[PATCH] D72589: Add GDB pretty printers for llvm::ilist, llvm::simple_ilist, and llvm::ilist_node.

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: debuginfo-tests/llvm-prettyprinters/gdb/prettyprinters.cpp:38
+}();
+auto SimpleIlist = [&]() {
+  llvm::simple_ilist<IlistNode, SimpleIlistTag> Result;
----------------
(looks like this capture should be removed, according to the lint check)


================
Comment at: llvm/utils/gdb-scripts/prettyprinters.py:370-373
+    except gdb.error:
+      # Fall back to base node that doesn't contain sentinel flag.
+      self.prev = val['Prev'].cast(pointer_type)
+      self.sentinel = None
----------------
Under what conditions does this fallback occur? Are those conditions tested?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72589/new/

https://reviews.llvm.org/D72589