[PATCH] D61901: AMDGPU: Assume xnack is enabled by default

Tue Jan 14 07:34:12 PST 2020

t-tye reopened this revision.
t-tye added a comment.
This revision is now accepted and ready to land.

If this is changing the user visible defaults then the processor table in AMDGPUUsage also needs to be updated and the change of compiler needs to be mentioned in the release notes.

Only targets that do not support XNACK should be marked as DoesNotSupportXNACK which means all gfx8/9/10 should not have DoesNotSupportXNACK as they do support XNACK (as defined in the processor table of AMDGPUUsage).

If an xnack option is given on a target that doe not support XNACK it would be helpful to give a error to the user and not silently ignore the request. In particular it should not cause  code object to be generated that does not have XNACK code in it yet is marked in the EFLAGS header that it does have XNACK.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61901/new/

https://reviews.llvm.org/D61901