[PATCH] D71546: [MachO] Fix detecting malformed DWARF.

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 14 05:26:16 PST 2020


ikudrin added a comment.

In D71546#1797665 <https://reviews.llvm.org/D71546#1797665>, @dblaikie wrote:

> Was this fixing an existing buildbot/test failure? (if not, it should probably have a test? If it did fix an existing failure - could you mention what that failure was?)


The main issue was that some valid length values were wrongly interpreted as reserved, which come from inconsistency in the DWARF3 documentation which was fixed in DWARF4. See D64622 <https://reviews.llvm.org/D64622> and http://lists.dwarfstd.org/pipermail/dwarf-discuss-dwarfstd.org/2008-June/003343.html for more details.

I have created D72695 <https://reviews.llvm.org/D72695> for the test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71546/new/

https://reviews.llvm.org/D71546





More information about the llvm-commits mailing list