[PATCH] D71896: [llvm-readobj][llvm-readelf][test] - Add a few more dynamic section tests.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 14 04:30:03 PST 2020
grimar added a comment.
In D71896#1801120 <https://reviews.llvm.org/D71896#1801120>, @jhenderson wrote:
> What are the formatting issues you are referring to in your description?
Things like below in `ELF/dynamic-tags.test`:
# GNU64-NEXT: 0x000000007fffffff (FILTER) Filter library: [U]
# GNU64-NEXT: 0x0000000012345678 (<unknown:>0x12345678) 0x8765432187654321
# GNU64-NEXT: 0x000000006abcdef0 (<unknown:>0x6abcdef0) 0x9988776655443322
# GNU64-NEXT: 0x0000000076543210 (<unknown:>0x76543210) 0x5555666677778888
# GNU64-NEXT: 0x0000000000000000 (NULL) 0x0
I.e. we need to have tests for both 32 and 64 bits I think to document the formatting we have.
(I'll address the other comments and update this patch soon.)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71896/new/
https://reviews.llvm.org/D71896
More information about the llvm-commits
mailing list