[PATCH] D71834: [DWARF] Fix DWARFDebugAranges to support 64-bit CU offsets.

Tue Jan 14 02:57:33 PST 2020

ikudrin marked 3 inline comments as done.
ikudrin added inline comments.

================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFDebugAranges.h:36
     explicit Range(uint64_t LowPC = -1ULL, uint64_t HighPC = -1ULL,
-                   uint32_t CUOffset = -1U)
+                   uint64_t CUOffset = -1U)
       : LowPC(LowPC), Length(HighPC - LowPC), CUOffset(CUOffset) {}
----------------
aprantl wrote:
> -1ULL? But really, these should be optionals, right?
Thanks for catching this!
Apparently, these default values are never used because the only call in `DWARFDebugAranges::construct()` provides all three arguments. But removing the default values is also seems to be out of the scope of the patch.

================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFDebugAranges.h:56

     uint64_t LowPC; /// Start of address range.
+    uint64_t Length; /// End of address range (not including this address).
----------------
aprantl wrote:
> Either:
> 
> ```
> /// Start of address range.
> uint64_t LowPC; 
> ```
> 
> or
> 
> ```
> uint64_t LowPC; ///< Start of address range.
> ```
> 
Fixing the style of the existing comments is out of the scope of this patch, no?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71834/new/

https://reviews.llvm.org/D71834