[PATCH] D72681: [ELF] --exclude-libs: don't assign VER_NDX_LOCAL to undefined symbols

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 14 01:34:30 PST 2020


grimar accepted this revision.
grimar added a comment.
This revision is now accepted and ready to land.

LGTM, but please wait for another possible comments too.



================
Comment at: lld/test/ELF/exclude-libs-undef.s:3
+## Test we don't assign VER_NDX_LOCAL to an undefined symbol.
+## If we does, an undefined weak will become non-preemptible,
+## and we will report an error when an R_PLT_PC (optimized to R_PC)
----------------
"we do" I think.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72681/new/

https://reviews.llvm.org/D72681





More information about the llvm-commits mailing list