[PATCH] D71835: [llvm-readobj] - Remove an excessive helper for printing dynamic tags.

Tue Jan 14 01:04:24 PST 2020

grimar added a comment.

In D71835#1817700 <https://reviews.llvm.org/D71835#1817700>, @MaskRay wrote:

> I think our goal is to make llvm-readobj -d and llvm-readelf -d consistent. It seems we have a preferable output in mind which is inconsistent with GNU readelf. I agree that omitting the value from the `(unknown)` column is better.
>
> `0x0000000012345678 (unknown) 0x8765432187654321`
>
> @grimar Can you send an email to the mailing list binutils at sourceware.org and ask whether they'd like to change?

I'd like to clarify. GNU readelf currently prints:

  0x0000000012345678 (<unknown>: 12345678) 0x8765432187654321
  0x000000006abcdef0 (Operating System specific: 6abcdef0) 0x9988776655443322
  0x0000000076543210 (Processor Specific: 76543210) 0x5555666677778888

Do you suggest to start using `(unknown)` everywhere?

  0x0000000012345678 (unknown) 0x8765432187654321
  0x000000006abcdef0 (unknown) 0x9988776655443322
  0x0000000076543210 (unknown) 0x5555666677778888

Or do you want to keep `Operating System specific` and `Processor Specific` text?
(I think James wants to keep them).

  0x0000000012345678 (unknown) 0x8765432187654321
  0x000000006abcdef0 (Operating System specific) 0x9988776655443322
  0x0000000076543210 (Processor Specific) 0x5555666677778888

Assuming we want to keep them, I am thinking about shortening and lower-casing:

  0x0000000012345678 (unknown) 0x8765432187654321
  0x000000006abcdef0 (OS specific) 0x9988776655443322
  0x0000000076543210 (processor specific) 0x5555666677778888

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71835/new/

https://reviews.llvm.org/D71835