[PATCH] D72681: [ELF] --exclude-libs: don't assign VER_NDX_LOCAL to undefined symbols

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

I think this is fine.
I'd suggest to add a comment to the test case (its generally helpfull in a long term, though I know we often do not add them in LLDs tests.)



================
Comment at: lld/test/ELF/exclude-libs-undef.s:6
+# RUN: llvm-ar rc %t.dir/t.a %t.o
+# RUN: ld.lld -shared --whole-archive --exclude-libs=t.a %t.dir/t.a -o %t.so
+# RUN: llvm-readelf --dyn-syms %t.so | FileCheck %s
----------------
Do you need both `t.a` and `%t.dir/t.a`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72681/new/

https://reviews.llvm.org/D72681