[PATCH] D72515: Add Targeted LiveDebugValues Tests That Exercise Specific Expected Behaviours

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added inline comments.


================
Comment at: llvm/test/DebugInfo/MIR/X86/livedebugvalues_basic_diamond.mir:30
+  !llvm.ident = !{!11}
+  !0 = distinct !DICompileUnit(language: DW_LANG_C_plus_plus, file: !1, producer: "clang version 8.0.0", isOptimized: true, runtimeVersion: 0, emissionKind: FullDebug, enums: !2, globals: !3, debugInfoForProfiling: true, nameTableKind: None)
+  !1 = !DIFile(filename: "main.cpp", directory: "F:\")
----------------
TWeaver wrote:
> djtodoro wrote:
> > (Nit) Please update the version of the compiler.
> Hi Dj,
> 
> thanks for your review.
> 
> All of the tests have clang 8.0 as their versions as they're all based on some samples written about a year ago now.
> 
> Are you wanting me to change the strings in the debug info to the latest version of clang or regenerate these samples?
> 
> the samples are hand modified from one base sample that was trimmed down from a larger test case.
> 
> 
Hi Tom,

Yes I just wanted the "clang version 10" as a string field there, since we are testing the LLVM 10 and somewhere outhere might be a testing tool parsing the metadata...
I mean, it is a very minor thing, other than that, everything looks fine! Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72515/new/

https://reviews.llvm.org/D72515