[PATCH] D72429: [mlir] Change the syntax of AffineMapAttr and IntegerSetAttr to avoid conflicts with function types.

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 13 22:43:55 PST 2020


mehdi_amini added a comment.

In D72429#1813367 <https://reviews.llvm.org/D72429#1813367>, @bondhugula wrote:

> The type is printed for each use because one'd like to know about the value used by looking at the op locally and without having to search for its definition -- the latter would be a readability killer.


I thought the type is printed for each use because they could appear before the def in a CFG?

Most programming languages are including the type for variable definitions only and not every use, yet they are readable, what is the fundamental difference you see in the IR?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72429/new/

https://reviews.llvm.org/D72429





More information about the llvm-commits mailing list