[PATCH] D72225: Align branches within 32-Byte boundary(Prefix padding)

Kan Shengchen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 13 17:36:51 PST 2020


skan marked 2 inline comments as done.
skan added a comment.

In D72225#1818149 <https://reviews.llvm.org/D72225#1818149>, @MaskRay wrote:

> @skan @craig.topper This patch introduces an unknown bug. I applied Diff 15 (https://reviews.llvm.org/D72225?id=237569) + D72463 <https://reviews.llvm.org/D72463> (clangDriver) + a local patch which enables `-mbranches-within-32B-boundaries` by default, then randonly picked 1000 tests and 40 failed. I will try providing a reproduce.
>
> NOP padding alone seems good.


Could you reproduce the fail with this patch only? Applying three patches together makes things complicated and can not prove there is something wrong. I am glad to wait for the reproduced fail for half day.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72225/new/

https://reviews.llvm.org/D72225





More information about the llvm-commits mailing list