[PATCH] D72569: [PowerPC][Future] Add prefixed instruction paddi to future CPU

[Nemanja Ivanovic via Phabricator via llvm-commits]

nemanjai added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/Disassembler/PPCDisassembler.cpp:367
   // Read the instruction in the proper endianness.
-  uint32_t Inst = IsLittleEndian ? support::endian::read32le(Bytes.data())
-                                 : support::endian::read32be(Bytes.data());
+  uint32_t Inst = ReadFunc(Bytes.data());
 
----------------
I think that according to Daniel's comment in https://reviews.llvm.org/D72574, we should be able to safely give `Inst` the type `uint64_t` in all paths and simply avoid having the template instantiated with a 32-bit integer altogether. This would allow us to not need the changes in TblGen.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72569/new/

https://reviews.llvm.org/D72569