[PATCH] D72523: [remark][diagnostics] Using clang diagnostic handler for IR input files

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 13 16:50:22 PST 2020


tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

LGTM. One more request for a comment below that I forgot to add earlier.



================
Comment at: clang/lib/CodeGen/CodeGenAction.cpp:154
     }
+    BackendConsumer(BackendAction Action, DiagnosticsEngine &Diags,
+                    const HeaderSearchOptions &HeaderSearchOpts,
----------------
Add comment as to what specific case this new constructor is for.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72523/new/

https://reviews.llvm.org/D72523





More information about the llvm-commits mailing list