[PATCH] D72663: [GlobalISel] Change representation of shuffle masks in MachineOperand.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 13 16:13:22 PST 2020


arsenm added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/MachineOperand.h:178
     unsigned Pred;           // For MO_Predicate
-    const Constant *ShuffleMask; // For MO_ShuffleMask
+    ArrayRef<int> ShuffleMask; // For MO_ShuffleMask
 
----------------
Won't this double the size of every MachineOperand? That's an extremely high cost


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72663/new/

https://reviews.llvm.org/D72663





More information about the llvm-commits mailing list