[PATCH] D69372: [X86][VARARG] Avoid spilling xmm vararg arguments.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 13 14:49:12 PST 2020


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:3442
 
+  SmallDenseSet<MCPhysReg, 8> guardedXmmRegs;
+  SmallVector<SDValue, 6> LiveGPRs;
----------------
First letter of variables should be capitalized.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:3580
+
+    if (guardedXmmRegs.size() > 0) {
+      if (MFI.hasVAStart()) {
----------------
!guardedXmmRegs.empty()


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69372/new/

https://reviews.llvm.org/D69372





More information about the llvm-commits mailing list