[PATCH] D72648: [ThinLTO/WPD] Remove an overly-aggressive assert

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson created this revision.
tejohnson added reviewers: evgeny777, aganea.
Herald added subscribers: dexonsmith, steven_wu, hiraditya, inglorion, mehdi_amini.
Herald added a project: LLVM.

An assert added to the index-based WPD was trying to verify that we only
have multiple vtables for a given guid when they are all non-external
linkage. This is too conservative because we may have multiple external
vtable with the same guid when they are in comdat. Remove the assert,
as we don't have comdat information in the index, the linker should
issue an error in this case.

See discussion on D71040 <https://reviews.llvm.org/D71040> for more information.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D72648

Files:
  llvm/lib/Transforms/IPO/WholeProgramDevirt.cpp
  llvm/test/ThinLTO/X86/Inputs/devirt_external_comdat_same_guid.ll
  llvm/test/ThinLTO/X86/devirt_external_comdat_same_guid.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72648.237777.patch
Type: text/x-patch
Size: 6418 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200113/f32d7ad6/attachment.bin>