[PATCH] D71040: [ThinLTO/WPD] Fix index-based WPD for alias vtables
Teresa Johnson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 13 14:11:48 PST 2020
tejohnson added a comment.
In D71040#1808470 <https://reviews.llvm.org/D71040#1808470>, @tejohnson wrote:
> In D71040#1787416 <https://reviews.llvm.org/D71040#1787416>, @evgeny777 wrote:
>
> > > Could you possibly try check-all or check-llvm? This problem was occuring in the LLVM unit tests.
> >
> > This did work. We have two vftable aliases with external linkage, that's why assertion fires. They're both attached to comdat, so there are no link errors.
> > May be just remove assertion?
>
>
> This appears to be an unrelated issue then, and should probably be fixed in a separate patch. Can this one be approved and go in, and I'll make sure I can repro and then fix this one?
Fix for assertion (remove it and add test) mailed in D72648 <https://reviews.llvm.org/D72648>.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71040/new/
https://reviews.llvm.org/D71040
More information about the llvm-commits
mailing list