[PATCH] D72470: [scudo][standalone] Fork support

Mon Jan 13 13:43:21 PST 2020

eugenis added inline comments.

================
Comment at: compiler-rt/lib/scudo/standalone/combined.h:31
 // https://reviews.llvm.org/D69265#inline-624315).
 static gwp_asan::GuardedPoolAllocator GuardedAlloc;
 #endif // GWP_ASAN_HOOKS
----------------
A static global in a header is not a great idea - every translation unit that includes this will get its own instance of gwp-asan, and only one of those will be initialized.

This needs to be moved to the wrappers, probably.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72470/new/

https://reviews.llvm.org/D72470