[PATCH] D68203: Add support for (expressing) vscale.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

The new IR intrinsic makes more sense.



================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:5139
+      int64_t MulImm = cast<ConstantSDNode>(N1->getOperand(0))->getSExtValue();
+      return getVScale(DL, VT, MulImm * N2C->getSExtValue());
+    }
----------------
efriedma wrote:
> This multiply can overflow.
This multiply can still overflow.  (If it's supposed to wrap, please use an unsigned multiply.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68203/new/

https://reviews.llvm.org/D68203