[PATCH] D72481: [mlir][EDSC] Refactor dependencies involving EDSCs.

Nicolas Vasilache via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 13 12:18:42 PST 2020


nicolasvasilache marked 4 inline comments as done.
nicolasvasilache added inline comments.


================
Comment at: mlir/lib/Dialect/Linalg/CMakeLists.txt:18
+add_dependencies(MLIRLinalgRegistration
 
+  MLIRLinalgOps
----------------
ftynse wrote:
> This may also need MLIRIR
done and tested by compiling targets independently, this surfaced a bunch of issues that are now fixed, thanks!


================
Comment at: mlir/lib/Dialect/Linalg/EDSC/CMakeLists.txt:10
+
+add_dependencies(MLIRLinalgEDSC
+  MLIREDSC
----------------
ftynse wrote:
> This also needs MLIRLoopOps and any other library it uses
done and tested by compiling targets independently, this surfaced a bunch of issues that are now fixed, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72481/new/

https://reviews.llvm.org/D72481





More information about the llvm-commits mailing list