[PATCH] D72490: Fix cmake for zlib

Saleem Abdulrasool via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 13 11:50:30 PST 2020


compnerd requested changes to this revision.
compnerd added a comment.
This revision now requires changes to proceed.

I'm not sure I understand the motivation for this change.  Can you please expand on that?  How are you using it that it doesn't work for you?  Additionally, `z` is definitely the wrong name, please compute that by using `get_file_name_component`, `CMAKE_SHARED_LIBRARY_PREFIX`, and `string(REGEX...)`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72490/new/

https://reviews.llvm.org/D72490





More information about the llvm-commits mailing list