[PATCH] D71875: [DWARF] Return Error from DWARFDebugArangeSet::extract().
Greg Clayton via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 13 10:07:13 PST 2020
clayborg added a comment.
lgtm with Error being returned everywhere now.
================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFContext.cpp:456
DWARFDebugArangeSet set;
- while (set.extract(arangesData, &offset))
- set.dump(OS);
+ while (arangesData.isValidOffset(offset))
+ if (Error E = set.extract(arangesData, &offset)) {
----------------
do we want {} on this while now?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71875/new/
https://reviews.llvm.org/D71875
More information about the llvm-commits
mailing list