[PATCH] D72567: [ELF] Avoid false-positive assert in getErrPlace()

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 13 10:07:12 PST 2020


MaskRay added inline comments.


================
Comment at: lld/ELF/Target.cpp:98
     auto *isec = cast<InputSection>(d);
     if (!isec->getParent())
       continue;
----------------
arichardson wrote:
> I could also add the `|| (isec->type & SHT_NOBITS)` to this if? Is that preferable?
Agree. `|| (isec->type & SHT_NOBITS)` here is preferable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72567/new/

https://reviews.llvm.org/D72567





More information about the llvm-commits mailing list