[PATCH] D72598: [VE] Minimal codegen for empty functions

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM with a few more nits



================
Comment at: llvm/lib/Target/VE/VEFrameLowering.cpp:306
+
+  return !(MFI.hasCalls()                 // has calls
+           || MRI.isPhysRegUsed(VE::SX18) // Too many registers needed
----------------
Capitalize comments and demorgan 


================
Comment at: llvm/lib/Target/VE/VEISelLowering.cpp:78
+                                             const MachineFunction &MF) const {
+  unsigned Reg = StringSwitch<unsigned>(RegName)
+                     .Case("sp", VE::SX11)    // Stack pointer
----------------
s/unsigned/Register


================
Comment at: llvm/lib/Target/VE/VEInstrInfo.cpp:105-107
+  BuildMI(BB, dl, TII.get(VE::LDSri), VE::SX61).addReg(VE::SX14).addImm(0x18);
+  BuildMI(BB, dl, TII.get(VE::ORri), VE::SX62).addReg(VE::SX0).addImm(0);
+  BuildMI(BB, dl, TII.get(VE::LEAzzi), VE::SX63).addImm(0x13b);
----------------
.add*s on separate line like other BuildMI calls? It was mixed in other files too


================
Comment at: llvm/lib/Target/VE/VEMCInstLower.cpp:40
+    report_fatal_error("unsupported operand type");
+    break;
+
----------------
dead break


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72598/new/

https://reviews.llvm.org/D72598