[PATCH] D72549: [TSan] Register threads created via pthread_create_from_mach_thread

Julian Lettner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 13 09:57:24 PST 2020


yln marked 2 inline comments as done.
yln added inline comments.


================
Comment at: compiler-rt/lib/tsan/rtl/tsan_platform_mac.cpp:208
+                                                pthread_key_t key,
+                                                const void *value) {
+  // These magic values are not part of the ABI.  Do not depend on them!
----------------
MadCoder wrote:
> nit: it should be `void *` not `const void *` ;) but it really doesn't matter for you
Thanks!  Fixed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72549/new/

https://reviews.llvm.org/D72549





More information about the llvm-commits mailing list