[PATCH] D72394: [mlir] Add skeleton implementation of loop.parallel, loop.yield and loop.yield.return operations.

[River Riddle via Phabricator via llvm-commits]

rriddle accepted this revision.
rriddle added inline comments.


================
Comment at: mlir/lib/Dialect/LoopOps/LoopOps.cpp:348
+      }))
+    return op.emitError() << "expected two arguments to reduce block of type "
+                          << type;
----------------
nit: You can use emitOpError to have the message prefixed with the operation name: `'foo.op' op <your-message>`


================
Comment at: mlir/lib/Dialect/LoopOps/LoopOps.cpp:353
+  if (!isa<ReduceReturnOp>(block.getTerminator()))
+    return op.emitError("The block inside reduce should be terminated with a "
+                        "'loop.reduce.return' op");
----------------
nit: use lower case to start the message


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72394/new/

https://reviews.llvm.org/D72394