[PATCH] D72554: [mlir] support building with BUILD_SHARED_LIBS=ON

[Stephen Neuendorffer via Phabricator via llvm-commits]

stephenneuendorffer added inline comments.


================
Comment at: mlir/cmake/modules/AddMLIR.cmake:11
+  # since MLIR cannot be built as shared libraries.
+  set(LIBTYPE STATIC)
+
----------------
OK, so if I understand correctly, this means that LLVM can be built using shared libraries, but MLIR is built as static libraries unless explicitly specified in the CMakeFiles.txt.   I think this is reasonably sane, and might be a decent stepping stone towards  a better solution.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72554/new/

https://reviews.llvm.org/D72554