[PATCH] D72260: AMDGPU/GlobalISel: Add pre-legalize combiner pass

[Austin Kerbow via Phabricator via llvm-commits]

kerbowa added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPU.h:34
+
+
 // R600 Passes
----------------
NITPICK: extra newline


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPreLegalizerCombiner.cpp:113
+
+AMDGPUPreLegalizerCombiner::AMDGPUPreLegalizerCombiner(bool IsOptNone)
+    : MachineFunctionPass(ID), IsOptNone(IsOptNone) {
----------------
I understand this stub pass is copied from AArch64, but the indentation style below doesn't really match the rest of the AMDGPU GlobalISel patches.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPreLegalizerCombiner.cpp:130
+  AMDGPUPreLegalizerCombinerInfo PCInfo(EnableOpt, F.hasOptSize(),
+                                         F.hasMinSize(), KB, MDT);
+  Combiner C(PCInfo, TPC);
----------------
NITPICK: indent


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72260/new/

https://reviews.llvm.org/D72260