[PATCH] D72515: Add Targeted LiveDebugValues Tests That Exercise Specific Expected Behaviours

[Tom Weaver via Phabricator via llvm-commits]

TWeaver marked 6 inline comments as done.
TWeaver added a comment.

thank you all for your valuable time.

added implicit-check-not=DBG_VALUE to all tests.
added extra coverage missing from one of the tests.
removed some trailing whitespace.
fixed few typo nits.



================
Comment at: llvm/test/DebugInfo/MIR/X86/livedebugvalues_basic_diamond.mir:30
+  !llvm.ident = !{!11}
+  !0 = distinct !DICompileUnit(language: DW_LANG_C_plus_plus, file: !1, producer: "clang version 8.0.0", isOptimized: true, runtimeVersion: 0, emissionKind: FullDebug, enums: !2, globals: !3, debugInfoForProfiling: true, nameTableKind: None)
+  !1 = !DIFile(filename: "main.cpp", directory: "F:\")
----------------
djtodoro wrote:
> (Nit) Please update the version of the compiler.
Hi Dj,

thanks for your review.

All of the tests have clang 8.0 as their versions as they're all based on some samples written about a year ago now.

Are you wanting me to change the strings in the debug info to the latest version of clang or regenerate these samples?

the samples are hand modified from one base sample that was trimmed down from a larger test case.




================
Comment at: llvm/test/DebugInfo/MIR/X86/livedebugvalues_basic_diamond_one_move.mir:17
+  ; CHECK-NOT:   DBG_VALUE $ebx, $noreg, !16, !DIExpression(), debug-location !17
+  ; CHECK-NOT:   DBG_VALUE $eax, $noreg, !16, !DIExpression(), debug-location !17
+
----------------
vsk wrote:
> Have you considered running FileCheck with `-implicit-check-not=DBG_VALUE`? That might be less brittle (e.g. it'd survive small changes to how DBG_VALUE is printed out).
Hi VSK,

I wasn't fully aware of the -implicit-check feature of FileCheck until you mentioned it.

I've added it to all tests and it actually flushed out a lack of coverage in one of the tests.

thank you very much for pointing this out. Some of the test cases have been significantly reduced as a result.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72515/new/

https://reviews.llvm.org/D72515