[PATCH] D70718: [AIX] Replace ExternalSymbolSDNode with a MCSymbolSDNode for memcpy/memset/memmove

Xiangling Liao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 13 09:19:15 PST 2020


Xiangling_L updated this revision to Diff 237705.
Xiangling_L marked 2 inline comments as done.
Xiangling_L added a comment.

A bug  is caught that IFunc is not supported on AIX, so we shouldn't have cast a `GlobalValue` to a `GlobalObject` for all PPC target.

I added an assertion about this, and prefer reviewers to take one more look and approve it if no concern raised. I should have caught this earlier, sorry for the inconvenience.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70718/new/

https://reviews.llvm.org/D70718

Files:
  llvm/lib/Target/PowerPC/PPCISelLowering.cpp
  llvm/test/CodeGen/PowerPC/aix-external-sym-sdnode-lowering.ll
  llvm/test/CodeGen/PowerPC/aix-user-defined-memcpy.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70718.237705.patch
Type: text/x-patch
Size: 11137 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200113/e4f933cc/attachment.bin>


More information about the llvm-commits mailing list