[PATCH] D72626: [compiler-rt/cmake] Don't attempt to ad-hoc sign for OS X

[Keno Fischer via Phabricator via llvm-commits]

loladiro created this revision.
loladiro added reviewers: kubamracek, eugenis.
Herald added subscribers: llvm-commits, Sanitizers, mgorny, dberris.
Herald added projects: Sanitizers, LLVM.

Revision rL301443 <https://reviews.llvm.org/rL301443> added an ad-hoc codesigning step when building compiler-rt
dylibs. My understanding is that this is needed for testing such dylibs in
the iOS simulator. However, adding such a step is problematic for cross
compilation to OS X from other platforms, as the codesign utility is
generally not available in a cross compilation environment. Since there is
AFAIK no benefit to ad-hoc signing these libraries on OS X, restrict the
extra codesign step to IOS.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D72626

Files:
  compiler-rt/cmake/Modules/AddCompilerRT.cmake


Index: compiler-rt/cmake/Modules/AddCompilerRT.cmake
===================================================================
--- compiler-rt/cmake/Modules/AddCompilerRT.cmake
+++ compiler-rt/cmake/Modules/AddCompilerRT.cmake
@@ -321,7 +321,7 @@
         set_target_properties(${libname} PROPERTIES IMPORT_PREFIX "")
         set_target_properties(${libname} PROPERTIES IMPORT_SUFFIX ".lib")
       endif()
-      if(APPLE)
+      if(IOS)
         # Ad-hoc sign the dylibs
         add_custom_command(TARGET ${libname}
           POST_BUILD  


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72626.237699.patch
Type: text/x-patch
Size: 538 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200113/fb865b60/attachment.bin>