[PATCH] D72580: [mlir][Linalg] Update ReshapeOp::build to be more idiomatic
Nicolas Vasilache via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 13 08:03:37 PST 2020
nicolasvasilache marked 2 inline comments as done.
nicolasvasilache added inline comments.
================
Comment at: mlir/test/EDSC/builder-api-test.cpp:986
+ linalg_reshape(memrefType, reshaped,
+ ArrayRef<ArrayRef<AffineExpr>>{{i, j}, k});
+
----------------
ftynse wrote:
> Can we have an AffineExpr with symbols here? Just to check that symbol removal machinery works.
I made it into an assertion, there is no removal but just an assertion that it is symbolless.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72580/new/
https://reviews.llvm.org/D72580
More information about the llvm-commits
mailing list