[PATCH] D71876: [DWARF] Support DWARF64 in DWARFDebugArangeSet.

[Igor Kudrin via Phabricator via llvm-commits]

ikudrin marked 2 inline comments as done.
ikudrin added inline comments.


================
Comment at: llvm/test/DebugInfo/X86/dwarfdump-debug-aranges-error-cases.s:71-72
+.ifdef CASE4
+## Length overrun for the DWARF64 case.
+# CHECK4: address range table at offset 0x0 has invalid length
+.Llen:
----------------
dblaikie wrote:
> Not sure if this needs its own test case - since it's the same error/code path for both 32 and 64 bit lengths. (& having only one test for length overrun would enable all the tests to be done in one object file/run, rather than separate RUN lines for each one (some systems, like Windows, have significant per-process overhead so it's nice to keep the total number of separate command invocations down if practical/convenient))
This checks that we handle the difference in the length of the initial length field in both formats appropriately. Running additional tests is not a problem anymore, as the tests are moved into a gtest-based suite.

As for continuing processing the table after an error, that requires its own patch, where it should be carefully considered, which errors are recoverable. It might be sophisticated, and I am a bit reluctant to do that without a good sample.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71876/new/

https://reviews.llvm.org/D71876