[PATCH] D72598: [VE] Minimal codegen for empty functions

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/VE/InstPrinter/VEInstPrinter.cpp:61
+    default:
+      O << (int)MO.getImm();
+      return;
----------------
Why bother with the truncation?


================
Comment at: llvm/lib/Target/VE/InstPrinter/VEInstPrinter.cpp:82-86
+  if (MO.isImm() && MO.getImm() == 0) {
+    // don't print "+0"
+  } else {
+    printOperand(MI, opNum + 1, STI, O);
+  }
----------------
Invert condition and avoid empty true block


================
Comment at: llvm/lib/Target/VE/VEFrameLowering.h:8
+//===----------------------------------------------------------------------===//
+//
+//
----------------
Drop empty comment section?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72598/new/

https://reviews.llvm.org/D72598