[PATCH] D72423: [DemandedBits] Improve accuracy of Add propagator
Erika via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 13 05:11:16 PST 2020
rrika added a comment.
In D72423#1815871 <https://reviews.llvm.org/D72423#1815871>, @nikic wrote:
> @rrika Performing these kinds of tests on IR is both quite inefficient and unnecessary complex. It would be better to extract the code logic (which just operates on APInts) into a separate file, which will allow you to easily test it, and also share the logic with other places doing demanded bits analysis, such as InstCombine and SelectionDAG.
Are you suggesting factoring out the logic for addition/subtraction only or all opcodes? Where should this new function live?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72423/new/
https://reviews.llvm.org/D72423
More information about the llvm-commits
mailing list