[PATCH] D72567: [ELF] Avoid false-positive assert in getErrPlace()
Alexander Richardson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 13 01:48:57 PST 2020
arichardson marked an inline comment as done.
arichardson added inline comments.
================
Comment at: lld/ELF/Target.cpp:98
auto *isec = cast<InputSection>(d);
if (!isec->getParent())
continue;
----------------
I could also add the `|| (isec->type & SHT_NOBITS)` to this if? Is that preferable?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72567/new/
https://reviews.llvm.org/D72567
More information about the llvm-commits
mailing list