[PATCH] D71870: [llvm-locstats] Add the --compare option

Mon Jan 13 01:21:27 PST 2020

djtodoro marked an inline comment as done.
djtodoro added a comment.

@aprantl Thanks for the comment, sorry for the late response, I was on the vacation.

In D71870#1810823 <https://reviews.llvm.org/D71870#1810823>, @aprantl wrote:

> How ubiquitous is matplotlib? I wonder if it might be better to textually print out a gnuplot file or something similar. OTOH the surface area in the code seems to be really small, so this may be fine.

I see the matplotlib is used within some of the LLVM Python tools, but I can investigate this further in order to see if the gnuplot is better option for this.

================
Comment at: llvm/utils/llvm-locstats/llvm-locstats.py:331
+    locstats_to_compare = parse_locstats(opts, binary_file_to_compare)
+    # Draw a plot whoing the difference in debug location coverage between
+    # two files.
----------------
dstenb wrote:
> whoing -> showing ?
Thanks!

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71870/new/

https://reviews.llvm.org/D71870