[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation
Hans Wennborg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 13 01:20:51 PST 2020
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
Looks good to me (with a minor comment). Thanks!
================
Comment at: clang/tools/driver/driver.cpp:271
+ unsigned long long Enable;
+ if (getAsUnsignedInteger(SpawnCC1Str, 10, Enable) || Enable > 1) {
+ llvm::errs() << "error: the value of the environment variable "
----------------
I think just checking SpawnCC1Str == "0" or == "1" would be easier.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69825/new/
https://reviews.llvm.org/D69825
More information about the llvm-commits
mailing list